Prechádzať zdrojové kódy

edge_topology should be made obsolete (edge_flaps is superior in a few ways)

Former-commit-id: 94d5631c702c23bd2840ef4224b9cb2f20a24676
Alec Jacobson 8 rokov pred
rodič
commit
87ca4a7e25
1 zmenil súbory, kde vykonal 7 pridanie a 2 odobranie
  1. 7 2
      include/igl/edge_topology.h

+ 7 - 2
include/igl/edge_topology.h

@@ -23,8 +23,13 @@ namespace igl
   // FE : #Fx3, Stores the Triangle-Edge relation
   // EF : #Ex2: Stores the Edge-Triangle relation
   //
-  // TODO: This seems to be a duplicate of edge_flaps.h
-  // TODO: This should not depend on V
+  // TODO: This seems to be a inferior duplicate of edge_flaps.h:
+  //   - unused input parameter V
+  //   - roughly 2x slower than edge_flaps
+  //   - outputs less information: edge_flaps reveals corner opposite edge
+  //   - FE uses non-standard and ambiguous order: FE(f,c) is merely an edge
+  //     incident on corner c of face f. In contrast, edge_flaps's EMAP(f,c) reveals
+  //     the edge _opposite_ corner c of face f
 template <typename DerivedV, typename DerivedF>
   IGL_INLINE void edge_topology(
     const Eigen::PlainObjectBase<DerivedV>& V,