Browse Source

warning that Hausdorff is not correct

Former-commit-id: 451f58d4355aca5bd4ed17fa57a3919ca3de157c
Alec Jacobson 8 years ago
parent
commit
5aebd31ef0
1 changed files with 7 additions and 2 deletions
  1. 7 2
      include/igl/hausdorff.h

+ 7 - 2
include/igl/hausdorff.h

@@ -19,6 +19,11 @@ namespace igl
   // d(A,B) = max ( max min d(a,b) , max min d(b,a) )
   // d(A,B) = max ( max min d(a,b) , max min d(b,a) )
   //                a∈A b∈B          b∈B a∈A
   //                a∈A b∈B          b∈B a∈A
   //
   //
+  // Known issue: This is only computing max(min(va,B),min(vb,A)). This is
+  // better than max(min(va,Vb),min(vb,Va)). This (at least) is missing
+  // "edge-edge" cases like the distance between the two different
+  // triangulations of a non-planar quad in 3D.
+  //
   // Inputs:
   // Inputs:
   //   VA  #VA by 3 list of vertex positions
   //   VA  #VA by 3 list of vertex positions
   //   FA  #FA by 3 list of face indices into VA
   //   FA  #FA by 3 list of face indices into VA
@@ -26,8 +31,8 @@ namespace igl
   //   FB  #FB by 3 list of face indices into VB
   //   FB  #FB by 3 list of face indices into VB
   // Outputs:
   // Outputs:
   //   d  hausdorff distance
   //   d  hausdorff distance
-  //   pair  2 by 3 list of "determiner points" so that pair(1,:) is from A and
-  //     pair(2,:) is from B
+  //   //pair  2 by 3 list of "determiner points" so that pair(1,:) is from A
+  //   //  and pair(2,:) is from B
   //
   //
   template <
   template <
     typename DerivedVA, 
     typename DerivedVA,